Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all day check in organization settings #1874

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Conversation

mdshamoon
Copy link
Member

Summary

Added all day check in organization settings

@mdshamoon mdshamoon self-assigned this Jan 24, 2022
@mdshamoon mdshamoon linked an issue Jan 24, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 24, 2022

@github-actions github-actions bot temporarily deployed to pull request January 24, 2022 07:53 Inactive
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1874 (934b059) into master (2e7f58e) will decrease coverage by 0.09%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   76.59%   76.50%   -0.10%     
==========================================
  Files         212      212              
  Lines        7285     7303      +18     
  Branches     1561     1567       +6     
==========================================
+ Hits         5580     5587       +7     
- Misses       1204     1209       +5     
- Partials      501      507       +6     
Impacted Files Coverage Δ
...ntainers/SettingList/Organisation/Organisation.tsx 72.00% <64.70%> (-2.79%) ⬇️
src/components/UI/Form/Input/Input.tsx 95.83% <100.00%> (ø)
src/components/UI/Form/TimePicker/TimePicker.tsx 78.94% <100.00%> (+1.16%) ⬆️
...onversations/ChatConversation/ChatConversation.tsx 68.18% <0.00%> (-5.74%) ⬇️
...es/ChatMessage/ChatMessageType/ChatMessageType.tsx 88.57% <0.00%> (-5.37%) ⬇️
src/containers/Form/FormLayout.tsx 64.01% <0.00%> (-0.47%) ⬇️
src/common/constants.ts 100.00% <0.00%> (ø)
src/graphql/queries/Simulator.ts 100.00% <0.00%> (ø)
...Chat/ChatConversations/MessageType/MessageType.tsx 100.00% <0.00%> (ø)
src/components/simulator/Simulator.tsx 63.97% <0.00%> (+0.19%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7f58e...934b059. Read the comment docs.

@github-actions github-actions bot temporarily deployed to pull request January 24, 2022 08:02 Inactive
@cypress
Copy link

cypress bot commented Jan 24, 2022



Test summary

180 0 0 0Flakiness 2


Run details

Project Glific
Status Passed
Commit 7898f1a ℹ️
Started Feb 9, 2022 9:51 AM
Ended Feb 9, 2022 10:12 AM
Duration 20:33 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

search/Search.spec.ts Flakiness
1 Searches > should edit search
staffmanagement/StaffManagement.spec.ts Flakiness
1 Staff Management > should redirect to edit screen

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions github-actions bot temporarily deployed to pull request February 7, 2022 07:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 7, 2022 07:40 Inactive
@mdshamoon mdshamoon requested a review from kurund February 7, 2022 07:49
@github-actions github-actions bot temporarily deployed to pull request February 7, 2022 07:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 9, 2022 09:44 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdshamoon

Working as expected. However, getting the below error message in the console after saving it.

index.js:1 Missing field 'organization' while writing result {
  "__typename": "Organization",
  "activeLanguages": [
    {

@mdshamoon
Copy link
Member Author

@mdshamoon

Working as expected. However, getting the below error message in the console after saving it.

index.js:1 Missing field 'organization' while writing result {
  "__typename": "Organization",
  "activeLanguages": [
    {

Cheked the issue. Seems its already there before these changes. Also checked for resolution but it seems to be an issue with the apollo client. apollographql/apollo-client#8677. Everyhting on our end in the code seems to be fine.

@mdshamoon mdshamoon requested a review from kurund February 11, 2022 06:20
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's go ahead and merge then.

@kurund kurund merged commit 54144f1 into master Feb 11, 2022
@kurund kurund deleted the feature/time-allday branch February 11, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Flow: UI enhancements
2 participants