Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add show_id to TVEpisode #6

Merged
merged 1 commit into from
Oct 25, 2022
Merged

add show_id to TVEpisode #6

merged 1 commit into from
Oct 25, 2022

Conversation

simonc56
Copy link
Collaborator

@simonc56 simonc56 commented Oct 25, 2022

follow dece4d0

Actually, to get the show of a TVEpisode we only have show name (self.show) which is not reliable because some shows have the same name.
The show trakt id is more reliable than show name because it is unique. This PR adds show_id attribute to TVEpisode.

Example : Top Boy and Top Boy 2019
A TVEpisode from Top Boy 2019 uses slug top-boy (made from slugify(self.show) ) instead of top-boy-2019 to fetch data from trakt api. Therefore data received is wrong.

@glensc glensc merged commit 76760b5 into glensc:main Oct 25, 2022
@glensc
Copy link
Owner

glensc commented Oct 25, 2022

Released with 3.4.9

@glensc
Copy link
Owner

glensc commented Jan 14, 2023

The initializer for TVEpisode.show_id was not added.

@glensc
Copy link
Owner

glensc commented Jan 14, 2023

yet adding it as def __init__(self, show, season, number=-1, show_id=None, **kwargs): triggers this._get rather this._build:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants