Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added get histroy #35

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

added get histroy #35

wants to merge 6 commits into from

Conversation

9Mad-Max5
Copy link

Added the get history function to package.
Not tested deeply

@glensc glensc marked this pull request as draft January 8, 2024 22:47
@glensc
Copy link
Owner

glensc commented Jan 8, 2024

please see the changes you've made. looks like you've deleted some code. commented out some code. not described why. so looks bogus. marking as draft. seems incomplete work.

and describe the change, and why.

also don't create pull request from your default branch. all changes to your main branch will end up in this pr.

.gitignore Outdated Show resolved Hide resolved
@9Mad-Max5
Copy link
Author

please see the changes you've made. looks like you've deleted some code. commented out some code. not described why. so looks bogus. marking as draft. seems incomplete work.

and describe the change, and why.

also don't create pull request from your default branch. all changes to your main branch will end up in this pr.

Thanks for the information, wasn't sure that all other changes will be put in this pull request as well.
My initial idea of this pr was just the changes inside sync.py.
I removed get_watched as it was not functional and replaced it according to the trakt api with get_history.
As history is now the correct term for the watched elements.
As the get_watched was not functional I removed it and commented out the deprecation warning.

In the tv.py I added the studios function which was probably not the correct place, but I didn't assume it would affect this pr.
It retrieves according to trakt api documentation a list of the studios from an tvshow.

Correction of the progress call:
-- return self._progress('collection')
++return self._progress('watched')
In line 344 I corrected the code as the give one not using the progress of an TVshow and more the collection which is in the trakt world a difference.

@glensc
Copy link
Owner

glensc commented Feb 9, 2024

different changes, different pr please. with appropriate description of changes. also remove change for version.

remove draft after you've completed your changes.

@@ -1 +1 @@
__version__ = "Unknown"
__version__ = "alpha"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this must not be modified. this is filled automatically by CI on release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants