Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--no-original-metadata" option to omit original metadata from METADATA.ome.xml #251

Merged
merged 2 commits into from
May 29, 2024

Conversation

melissalinkert
Copy link
Member

Fixes #250.

As the test demonstrates, converting input data that has original metadata with the new --no-original-metadata option should result in a METADATA.ome.xml that does not contain OriginalMetadata annotations. Default behavior should be unchanged.

@dsudar
Copy link

dsudar commented May 22, 2024

I pulled in this PR, built, and ran a few tests on my data. All worked fine. Thumbs-up from me.

@melissalinkert melissalinkert requested a review from sbesson May 22, 2024 15:20
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works as expected comparing the METADATA.ome.xml produced by bioformats2raw with and without --no-original-metadata.

Is it worth also adding the option to the README? Otherwise, let's get this merged

@melissalinkert
Copy link
Member Author

Is it worth also adding the option to the README? Otherwise, let's get this merged

Done in 76c993a.

@sbesson sbesson merged commit b5b540a into glencoesoftware:master May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add -no-sas option as exists in bfconvert
3 participants