Merge pull request #233 from melissalinkert/fix-logging-config

Move logging configuration to beginning of call() method
glencoesoftware · Jan 15, 2024 · 58f6e40 · 58f6e40
2 parents 3def4ea + 75cc25a
commit 58f6e40
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -96,6 +96,8 @@ distributions {
 }
 
 startScripts {
+  defaultJvmOpts = ['--add-opens', 'java.base/java.lang=ALL-UNNAMED']
+
   // placing logback.xml somewhere under src/dist/lib/ keeps it out of
   // bioformats2raw-*.jar but automatically includes it in the distribution zip
   // the directory containing logback.xml must be explicitly added to the

diff --git a/src/main/java/com/glencoesoftware/bioformats2raw/Converter.java b/src/main/java/com/glencoesoftware/bioformats2raw/Converter.java
@@ -1090,6 +1090,10 @@ public DimensionOrder getDimensionOrder() {
    */
   @Override
   public Integer call() throws Exception {
+    ch.qos.logback.classic.Logger root = (ch.qos.logback.classic.Logger)
+        LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME);
+    root.setLevel(Level.toLevel(logLevel));
+
     if (printVersion) {
       String version = Optional.ofNullable(
         this.getClass().getPackage().getImplementationVersion()
@@ -1118,10 +1122,6 @@ public Integer call() throws Exception {
 
     OpenCVTools.loadOpenCV();
 
-    ch.qos.logback.classic.Logger root = (ch.qos.logback.classic.Logger)
-        LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME);
-    root.setLevel(Level.toLevel(logLevel));
-
     if (progressBars) {
       setProgressListener(new ProgressBarListener(logLevel));
     }