Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-workflows): added initial support for Argo workflows #230

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jakepage91
Copy link
Contributor

I added support for Argo-workflows. I have tested it and it works.

It turns out the that deployment was of argo-workflows was not to be deployed in the argocd namespace, the docs recommends for it to be deployed in the argo namespace.

One thing that I noticed regarding the Entrypoint is the following peculiarity that some users might find confusing:

Note: The URL uses https and not http. Navigating to http will result in a server-side error.
Due to the self-signed certificate, you will receive a TLS error which you will need to manually approve.

@jakepage91 jakepage91 requested a review from pmig as a code owner July 16, 2024 20:29
@jakepage91 jakepage91 force-pushed the add-argo-workflows-support branch 2 times, most recently from 1328ac8 to 0a134e1 Compare July 16, 2024 20:56
Copy link
Member

@pmig pmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like your change removed a bunch of new lines at the end of untouched files.

I find it a little wired that argo recommends following namespaces:

  • argo-cd -> argocd
  • argo-workflows -> argo
  • argo-events -> argo-events

@christophenne @kosmoz what would be your opinion in installion all argo packages into a argo-system namespace ?

@jakepage91 jakepage91 requested a review from pmig July 17, 2024 09:31
pmig
pmig previously approved these changes Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants