Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reporting for Healthchecks #89

Closed
wants to merge 1 commit into from
Closed

Conversation

jamesob
Copy link

@jamesob jamesob commented Sep 18, 2023

Adds ability to ping Healthchecks instances upon success.

@jamesob jamesob force-pushed the master branch 2 times, most recently from defd05f to 571cd5e Compare September 18, 2023 13:45
@gjcarneiro
Copy link
Owner

To be frank, I'm sceptic that this is needed at all. You already have the ability of running shell commands. You could just as easily run a curl to ping healthchecks. Plus the PR lacks unit tests.

@gjcarneiro gjcarneiro closed this Mar 23, 2024
@gjcarneiro gjcarneiro reopened this Mar 23, 2024
@jamesob
Copy link
Author

jamesob commented Apr 28, 2024

Makes sense. Closing this.

@jamesob jamesob closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants