Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Persist shell(bash,zsh,fish) histories between workspace reboots #920

Closed
wants to merge 3 commits into from

Conversation

axonasif
Copy link
Member

@axonasif axonasif commented Sep 2, 2022

Description

As the title says. It will only help for workspace reboots but not across workspace(s)

Related Issue(s)

Fixes #

How to test

  • Create a workspace based on axonasif/workspace-base from your .gitpod.yml (i.e image: axonasif/workspace-base)
  • Run some random shell commands
  • Stop the workspace
  • Restart
  • Run history to check

Release Notes

Documentation

@axonasif axonasif requested a review from a team September 2, 2022 19:14
@gitpod-io
Copy link

gitpod-io bot commented Sep 2, 2022

@gitpod-staging
Copy link

gitpod-staging bot commented Sep 2, 2022

@kylos101
Copy link
Collaborator

kylos101 commented Sep 2, 2022

👋 @axonasif for now, I'm going to shift this back to draft, so that we can have some conversation. 🙏

@loujaybee @mbrevoort, this seems related to gitpod-io/gitpod#9019, where we didn't necessarily agree on how terminal history should be shared. My preference would be for this to be a product led conversation, followed by a related implementation.

Related:
gitpod-io/gitpod#9019 (comment)
gitpod-io/gitpod#9019 (comment)
gitpod-io/gitpod#9019 (comment)
gitpod-io/gitpod#9019 (comment)
gitpod-io/gitpod#9019 (comment)

@kylos101 kylos101 marked this pull request as draft September 2, 2022 19:48
@kylos101 kylos101 removed the request for review from a team September 2, 2022 20:09
@kylos101
Copy link
Collaborator

kylos101 commented Feb 8, 2023

👋 closing for now @axonasif, I need to tidy up the list of PRs, can we can revisit in the future when there's bandwidth and alignment.

cc: @loujaybee

@kylos101 kylos101 closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants