Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FORBIDDEN_SLUGS #7320

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Remove FORBIDDEN_SLUGS #7320

merged 2 commits into from
Jan 5, 2022

Conversation

championshuttler
Copy link
Contributor

@championshuttler championshuttler commented Dec 20, 2021 •
edited
Loading

Description

Related Issue(s)

Fixes #6929

How to test

Release Notes

NONE

Documentation

@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Hi @championshuttler Thanks for your contribution, and could you please use our PR template? 🙏

@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-db-fork.0

@JanKoehnlein
Copy link
Contributor

Hi @championshuttler, thanks for the contribution! Unfortunately it doesn't compile yet

src/typeorm/team-db-impl.ts(7,1): error TS6133: 'blocklist' is declared but its value is never read.

I think the blocklist should still be considered.

Hint: You can compile that component locally by running

leeway build components/gitpod-db:lib

@stale
Copy link

stale bot commented Jan 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 1, 2022
@JanKoehnlein JanKoehnlein added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Jan 3, 2022
@JanKoehnlein
Copy link
Contributor

@championshuttler Sorry for being unresponsive. Could you please re-enable the blocklist checking?

@JanKoehnlein
Copy link
Contributor

I am merging this. Thanks a lot for this contribution, @championshuttler !

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Jan 5, 2022
@roboquat
Copy link
Contributor

roboquat commented Jan 5, 2022

LGTM label has been added.

Git tree hash: 197b0abd989818057641acc6330b4cedd85b9a90

@roboquat
Copy link
Contributor

roboquat commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #6929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 2479e48 into gitpod-io:main Jan 5, 2022
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JanKoehnlein JanKoehnlein

Labels
approved cla: accepted ✔️ community-contribution deployed: webapp Meta team change is running in production deployed Change is completely running in production meta: never-stale This issue can never become stale release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[db] remove FORBIDDEN_SLUGS
4 participants
@championshuttler @iQQBot @JanKoehnlein @roboquat