Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): redirect /memes to the website #6878

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Conversation

ghuntley
Copy link
Contributor

Description

It turns out folks are starting to create Gitpod memes. Let's collect them!

Related Issue(s)

Relates to https://github.com/gitpod-io/website/pull/1281
Relates to #6877

How to test

/memes should head to our website once https://github.com/gitpod-io/website/pull/1281 is merged.

Release Notes

NONE

Documentation

@roboquat roboquat added release-note-none team: webapp Issue belongs to the WebApp team size/XS labels Nov 25, 2021
@JanKoehnlein
Copy link
Contributor

We should then also add it to the FORBIDDEN_SLUGS, shouldn't we? Is that worth it?

@gtsiolis
Copy link
Contributor

We should then also add it to the FORBIDDEN_SLUGS, shouldn't we?

@JanKoehnlein I could be wrong but now that we have a dedicated slug (/t/:team) for teams (see #5544), maybe there's no need to use a fixed list of forbidden slugs and we could potentially remove this list, no? Cc @AlexTugarev @svenefftinge

@JanKoehnlein
Copy link
Contributor

@gtsiolis Yes, you're right, thanks

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00cc4c8752827211ac0de3d4919407c39dbe65bc

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Nov 26, 2021

/werft run

👍 started the job as gitpod-build-ghuntley-patch-1.1

@JanKoehnlein
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #6877

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit b35ed67 into main Nov 26, 2021
@roboquat roboquat deleted the ghuntley-patch-1 branch November 26, 2021 14:49
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants