Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oidc] Fix the HEAD method call that checks reachability #20474

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

nandajavarma
Copy link
Contributor

@nandajavarma nandajavarma commented Dec 20, 2024

Description

We are checking connectivity with the root of issuer, which might fail if the root is not serving anything. We sometimes get a 503 on this endpoint. So this PR replaces it to call .well-known/openid-configuration endpoint which should exist if it is a valid OIDC service

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member

geropl commented Dec 20, 2024

Creating a preview to test the SSO integration... 👀

@geropl
Copy link
Member

geropl commented Dec 20, 2024

@nandajavarma I had to push a fix for something I broke last week 😢

Otherwise, this works fine:
image

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine! ✔️

@geropl
Copy link
Member

geropl commented Dec 20, 2024

/unblock

@geropl
Copy link
Member

geropl commented Dec 20, 2024

/unhold

@roboquat roboquat merged commit 4bd9924 into main Dec 20, 2024
17 checks passed
@roboquat roboquat deleted the nvn/fix-oidc-issuer-check branch December 20, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants