Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Fix bottom page margins for Prebuilds, Repositories and Insights #20455

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

filiptronicek
Copy link
Member

Description

The pages right now did not properly keep their distance from the end of the viewport, making the last element hard to reach on mobile, unreadable and aesthetically displeasing.

Before After
image image

Related Issue(s)

Fixes #

How to test

I tested these changes in a preview environment for another PR (see screenshots). Feel free to trigger a preview env for this one, but you'll also have to fill up the page with entities (such as prebuilds, repos or workspaces for insights) to observe the fixed margins.

/hold

I forgor initially 💀
@roboquat roboquat added size/S and removed size/XS labels Dec 16, 2024
@roboquat roboquat merged commit be9e7a8 into main Dec 16, 2024
18 checks passed
@roboquat roboquat deleted the ft/fix-bottom-page-spacings branch December 16, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants