Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace YouTube with Mux for Gitpod demo video #20444

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

filiptronicek
Copy link
Member

Description

Uses Mux for the demo video because of some Enterprise networking restrictions of YouTube. We already use Mux in Flex, so this was a pretty easy migration.

Related Issue(s)

Fixes CLC-974
Fixes CLC-975

How to test

  1. Go to https://ft-muxier-videos.preview.gitpod-dev.com/workspaces
  2. Observe the welcome video can still be played

/hold

Copy link

socket-security bot commented Dec 12, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@mux/[email protected] Transitive: environment, network +13 45.6 MB mux-npmjs

View full report↗︎

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@roboquat roboquat merged commit eaf1055 into main Dec 17, 2024
18 checks passed
@roboquat roboquat deleted the ft/muxier-videos branch December 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants