-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] fix more revealing BB error logs #20402
Conversation
components/server/src/bitbucket-server/bitbucket-server-context-parser.ts
Show resolved
Hide resolved
@@ -88,7 +88,11 @@ export class BitbucketServerContextParser extends AbstractContextParser implemen | |||
return await this.handleNavigatorContext(ctx, user, repoKind, host, owner, repoName, more); | |||
} catch (e) { | |||
span.addTags({ contextUrl }).log({ error: e }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
span.log is using the original e as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's expected, since I'm happy to preserve the details in the log span, just don't want to directly log it in the console for tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
A follow-up for #20400
/hold