Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] fix more revealing BB error logs #20402

Merged
merged 6 commits into from
Nov 30, 2024
Merged

[server] fix more revealing BB error logs #20402

merged 6 commits into from
Nov 30, 2024

Conversation

filiptronicek
Copy link
Member

Description

A follow-up for #20400

/hold

@@ -88,7 +88,11 @@ export class BitbucketServerContextParser extends AbstractContextParser implemen
return await this.handleNavigatorContext(ctx, user, repoKind, host, owner, repoName, more);
} catch (e) {
span.addTags({ contextUrl }).log({ error: e });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

span.log is using the original e as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's expected, since I'm happy to preserve the details in the log span, just don't want to directly log it in the console for tests.

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@filiptronicek filiptronicek self-assigned this Nov 30, 2024
@roboquat roboquat merged commit c4d64c0 into main Nov 30, 2024
18 checks passed
@roboquat roboquat deleted the ft/fix-bb-test-logs branch November 30, 2024 19:23
@filiptronicek filiptronicek mentioned this pull request Nov 30, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants