Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get more insights on workspace image #20356

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Get more insights on workspace image #20356

merged 5 commits into from
Nov 12, 2024

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Nov 11, 2024 •
edited by github-actions bot
Loading

Description

Get more insights on workspace image

Related Issue(s)

Fixes CLC-883

How to test

  1. start a workspace in this preview env, you cloud try different workspace images or different IDEs
  2. check file /workspace/.gitpod/image, you should able to see workspace image ref and size
  3. use kubectl get ws $instanceId -oyaml in status, you cloud see same image info

image
image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@iQQBot iQQBot requested review from a team as code owners November 11, 2024 07:35
@iQQBot iQQBot marked this pull request as draft November 11, 2024 07:35
@geropl
Copy link
Member

geropl commented Nov 11, 2024

Nice, this looks really neat! We could make a lot of this. ✨

@iQQBot iQQBot marked this pull request as ready for review November 11, 2024 11:46
@iQQBot iQQBot changed the title [WIP] Get more insights on workspace image Get more insights on workspace image Nov 11, 2024
geropl
geropl approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM*, tested and works! ✔️

*: Please address https://github.com/gitpod-io/gitpod/pull/20356/files#r1837619723 before merging! 🙏

@geropl
Copy link
Member

geropl commented Nov 12, 2024

Tested and still works nicely, let's go! 🚀

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 12, 2024

/unhold

@roboquat roboquat merged commit 66a1ba0 into main Nov 12, 2024
17 checks passed
@roboquat roboquat deleted the pd/CLC-883 branch November 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
size/XL team: team-engine team: team-enterprise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iQQBot @geropl @roboquat