Enable collaborators #20353
Enable collaborators #20353
Conversation
| @@ -128,15 +128,12 @@ export function deduplicateAndFilterRepositories( | |||
| if (results.length === 0) { | |||
| // If the searchString is a URL, and it's not present in the proposed results, "artificially" add it here. | |||
| if (isValidGitUrl(searchString)) { | |||
| console.log("It's valid man"); | |||
There was a problem hiding this comment.
These super rad debug logs I accidentally left in with #20287. Yikes!
| ); | ||
| // todo(ft): solve for this case with collaborators who can't select projects directly |
There was a problem hiding this comment.
I'd love ideas around this: how can we not block collaborators if a repo they're working on gets imported twice? Or, in the very least, how do we educate members and owners about this possibility?
It's admittedly a case on the edge™, but IMO worth considering.
There was a problem hiding this comment.
todo: file an issue for this
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
meta: stale
|
It looks like activity-triggered prebuilds get into some weird state when triggered by collaborators. I'm investigating this |
| @@ -88,7 +88,7 @@ export const sortSuggestedRepositories = (repos: SuggestedRepositoryWithSorting[ | |||
| uniqueRepositories = uniqueRepositories.map((repo) => { | |||
| if (repo.projectId && !repo.projectName) { | |||
| delete repo.projectId; | |||
| delete projectURLs[projectURLs.indexOf(repo.url)]; | |||
| projectURLs = projectURLs.filter((url) => url !== repo.url); | |||
There was a problem hiding this comment.
This deletion would not work properly when you had two repos with the same project URL. Because we're iterating over the unique repos, it would clean up only the first occurrence of the project URL, instead of cleaning up all of them, leaving an incorrect state in projectURLs.
Description
Makes the following changes to the Collaborator role:
Important
Heads up! This also enables collaborators to trigger prebuilds via our standard activity-based prebuilds trigger mechanism.
To be merged sometime around November 25th to give users a heads-up.
Related Issue(s)
Fixes CLC-815
How to test
HELLO_VARIABLES) and it should be prebuilt.Documentation
This does require documentation changes. I will work on those as we get closer to the merge date