[dashboard] Fix GitHub app integration URL in user settings

[Siddhant-K-code]

Description

Bug got introduced in #19057 (cc: @AlexTugarev), which confuses the appRedirectUrl with GitHub App settings url (which is a constant URL for every user with GitHub App Id). See linked linear issue for more details.

Related Issue(s)

Fixes EXP-1152

How to test

• Open preview environment & complete setup w/ GitHub as Git provider.
• Go to user integrations settings (/user/integrations) and click on three dots in GitHub item list.
• Click on Manage on github.com & see fixed URL.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

• 🏷️ Name - siddhant-e7c7afcfb57
• 🔗 URL - siddhant-e7c7afcfb57.preview.gitpod-dev.com/workspaces.
• 📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
• 📦 Version - siddhant-exp-1152-github-integration-manage-on-githubcom-button-takes-to-wrong-gha.22319
• 🗒️ Logs - GCP Logs Explorer

Build Options

Build

• /werft with-werft
  Run the build with werft instead of GHA
• leeway-no-cache
• /werft no-test
  Run Leeway with --dont-test

Publish

• /werft publish-to-npm
• /werft publish-to-jb-marketplace

Installer

• analytics=segment
• with-dedicated-emulation
• workspace-feature-flags
  Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-gce-vm
  If enabled this will create the environment on GCE infra
• /werft preemptible
  Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
• with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
• with-monitoring

/hold

[AlexTugarev]

Hi @Siddhant-K-code!
Thanks for spotting this.
Indeed, the path is wrong. It should be /settings/applications.
The proposed change doesn't work in Dedicated context, unfortunately.

[Siddhant-K-code]

Indeed, the path is wrong. It should be /settings/applications.

Did the changes in 264efb4, but this seems confusing (from UX pov) if users have multiple oAuth Apps installed.

---

The proposed change doesn't work in Dedicated context, unfortunately.

I think, this won't be true for all other users in Gitpod Cloud & Dedicated because (assuming) they would be using Gitpod GitHub OAuth App. I think, this would be true in our internal use case to use a custom GitHub App for dedicated.

[Siddhant-K-code]

/unhold

Staled