Migrate gRPC workspaceService other workspace related method #19118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
do-not-merge/hold
size/XS
size/XL
size/XXL
and removed
size/XS
size/XL
labels
mustard-mh
force-pushed
the
hw/papi-ws-related
branch
from
a8c3b73 to
e732ff7
Compare
mustard-mh
force-pushed
the
hw/papi-ws-related
branch
from
e732ff7 to
6a9c5d5
Compare
akosyakov
reviewed
Nov 23, 2023
mustard-mh
force-pushed
the
hw/papi-ws-related
branch
from
6a9c5d5 to
e5250bb
Compare
akosyakov
reviewed
Nov 24, 2023
akosyakov
reviewed
Nov 24, 2023
|
|
||
| const tasks: Array<Promise<any>> = []; | ||
|
|
||
| if (request.name) { |
There was a problem hiding this comment.
if there are not updates provided other API will throw invlalid argument, we should be consisten.
akosyakov
reviewed
Nov 24, 2023
akosyakov
reviewed
Nov 24, 2023
mustard-mh
force-pushed
the
hw/papi-ws-related
branch
from
e5250bb to
62860ec
Compare
akosyakov
reviewed
Dec 5, 2023
akosyakov
reviewed
Dec 5, 2023
akosyakov
reviewed
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at cffb252
Updated
README.mdto useGitpod1instead ofGitpodas an example of how to edit files in Gitpod. This is a minor change for demonstration purposes only.Related Issue(s)
Fixes #
How to test
Related methods should work like before
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold