[server] Removes unused RepositoryService.canInstall #19112
Conversation
We're no longer supporting `/prebuild` in context parser, thus this is obsolete.
| @@ -1122,30 +1120,6 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable { | |||
| context = WithDefaultConfig.mark(context); | |||
| } | |||
|
|
|||
| // if this is an explicit prebuild, check if the user wants to install an app. | |||
There was a problem hiding this comment.
This is no longer supported for quite a while, i.e. context may never get parsed to StartPrebuildContext and reach createWorkspace here.
StartPrebuildContext is used to encapsulate a rich context in prebuild manager, which then uses this as input for workspace starter.
There was a problem hiding this comment.
I'm missing the context atm to verify this
That can be taken quite literally ;-)
https://gitpod.io/new/#prebuild/https://github.com/gitpod-io/gitpod
☝🏻 this results in that 👇🏻
We're sorry, there seems to have been an error.
Error: Couldn't parse context 'prebuild/https://github.com/gitpod-io/gitpod'
But in createWorkspace the cold path was never removed. 🤷🏻♂️
There was a problem hiding this comment.
Quick test on the preview env:
https://at-remove-f7bcae44fe.preview.gitpod-dev.com/new/#https://github.com/AlexTugarev/bel ✔️ (workspace is starting fine)
|
/unhold |
Description
PR to remove unused code.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at ac7fe43
This pull request simplifies and cleans up the code of various classes and files related to prebuilds and repository services. It removes unused dependencies, methods, imports, and tests, and refactors some constructors and helper methods. The overall purpose is to improve code quality, consistency, and performance.
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold