Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] fix tsconfig #19111

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[build] fix tsconfig #19111

merged 1 commit into from
Nov 22, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Nov 22, 2023

Description

remove unnecessary rootDir which causes the .tsbuildinfo file to be generated in a bad place.

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 912edf8

Remove rootDir option from tsconfig.json for gitpod-protocol component. This simplifies the TypeScript configuration and aligns it with other components.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 602fd5e into main Nov 22, 2023
40 of 41 checks passed
@roboquat roboquat deleted the se/fix-tsconfig branch November 22, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants