[public-api] migrate ssh service #19110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
reviewed
Nov 22, 2023
| } | ||
|
|
||
| async deleteSSHPublicKey(req: PartialMessage<DeleteSSHPublicKeyRequest>): Promise<DeleteSSHPublicKeyResponse> { | ||
| if (!req.sshKeyId) { |
There was a problem hiding this comment.
JSON-RPC and gRPC validate is not aligned
There was a problem hiding this comment.
I see that uuid check is not done in other json-rpc files, only in new api files
|
Build is failed, will take a look 💄 later today if you're not online. cc @jeanp413 |
|
Preview is ready, settings looks good. But not sure about the 
|
|
If it's not related to this PR, then we just go rebase and merge it |
|
Just checked with Gitpod Cloud, that we don't have last used display in settings. Ignore this if that's how we're going to achieve it |
mustard-mh
approved these changes
Nov 22, 2023
jeanp413
force-pushed
the
jp/hurt-parakeet
branch
from
56832aa to
1a51fbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at f2cc974
This pull request refactors the dashboard and the public API to use the new SSH service and the SSHPublicKey protobuf class, instead of the deprecated server service and the UserSSHPublicKeyValue class. It also renames the id field of the DeleteSSHPublicKeyRequest message to ssh_key_id, and removes some unused files and imports.
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold