cli: use the gitpod endpoint for analytics #19109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Checked segment go package https://github.com/segmentio/analytics-go/blob/8e6be0b5309d5dce4f268634219d307518f85285/analytics.go#L285
LGTM
mustard-mh
reviewed
Nov 23, 2023
mustard-mh
reviewed
Nov 23, 2023
mustard-mh
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the proxy which lives on every gitpod instance instead of talking to segment directly.
Depends on https://github.com/gitpod-io/gitpod-dedicated/pull/2501 for testing.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 5b5cf95
This pull request improves the telemetry system for self-hosted Gitpod installations by allowing different host names and segment endpoints, and by hiding the segment key from untrusted builds. It modifies the
telemetry.Initfunction and theroot.gofile to pass and use the host name parameter.Related Issue(s)
Fixes EXP-957
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold