[dashboard/server] app error conversion based on error details #19103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/app_error_conversion
branch
4 times, most recently
from
58c4985 to
77afcbf
Compare
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 6949222385
|
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 6955542072
|
akosyakov
force-pushed
the
ak/app_error_conversion
branch
from
77afcbf to
84c824e
Compare
akosyakov
force-pushed
the
ak/app_error_conversion
branch
from
84c824e to
39651e3
Compare
|
Testing: ✔️ Errors in parsed config ✔️ Missing OAuth approval from repo owner |
AlexTugarev
reviewed
Nov 22, 2023
| const data = <UnauthorizedError.Data>{ host, scopes, messageHint: messageHint || "unauthorized" }; | ||
| const error = Object.assign(new Error(message), { data }); | ||
| return error; | ||
| return new UnauthorizedRepositoryAccessError({ |
There was a problem hiding this comment.
Thanks for providing a smooth transitioning path! 🙇🏻
This feels great! Not touching the call sites but still converting 👍🏻
akosyakov
force-pushed
the
ak/app_error_conversion
branch
from
39651e3 to
6453026
Compare
AlexTugarev
approved these changes
Nov 22, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at 9e624aa
Refactored and improved the error handling logic in the server and dashboard components, using new subclasses of
ApplicationErrorwith protobuf messages and predefined error codes. Removed unused code and props related to errors.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold