-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] fix broken integration test #19084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iQQBot manual invocation now fails on Configuration: https://github.com/gitpod-io/gitpod/actions/runs/6893471538 (I tried twice, same failure).
not related |
Ah, good catch. I see you are testing in https://github.com/gitpod-io/gitpod/actions/runs/6893809672/job/18754262716, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/unhold |
/hold |
@kylos101 Do you think in integration test we can use not preemptible machine? looks like VM got deleted 5min after created... |
Oh, workspace integration test using harvester, not GCE |
We run the tests on every merge, it'd be ideal to continue using preemptible.
What makes you say? |
sorry, I read it wrong. |
/unhold |
Description
[action] fix broken integration test
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at bb4cae7
Set
preemptible
option totrue
for cluster creation steps in three GitHub workflows. This reduces the cost of running integration tests and checking regressions by allowing Google Cloud to terminate the clusters when needed.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold