Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] fix broken integration test #19084

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[action] fix broken integration test #19084

merged 1 commit into from
Nov 16, 2023

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Nov 16, 2023

Description

[action] fix broken integration test

image
Summary generated by Copilot

🤖[deprecated] Generated by Copilot at bb4cae7

Set preemptible option to true for cluster creation steps in three GitHub workflows. This reduces the cost of running integration tests and checking regressions by allowing Google Cloud to terminate the clusters when needed.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iQQBot manual invocation now fails on Configuration: https://github.com/gitpod-io/gitpod/actions/runs/6893471538 (I tried twice, same failure).

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 16, 2023

@iQQBot manual invocation now fails on Configuration: https://github.com/gitpod-io/gitpod/actions/runs/6893471538 (I tried twice, same failure).

image not related

@kylos101
Copy link
Contributor

Ah, good catch. I see you are testing in https://github.com/gitpod-io/gitpod/actions/runs/6893809672/job/18754262716, thank you!

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 16, 2023

/unhold

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 16, 2023

/hold

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 16, 2023

@kylos101 Do you think in integration test we can use not preemptible machine?

image

looks like VM got deleted 5min after created...

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 16, 2023

Oh, workspace integration test using harvester, not GCE

@kylos101
Copy link
Contributor

We run the tests on every merge, it'd be ideal to continue using preemptible.

Oh, workspace integration test using harvester, not GCE

What makes you say?

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 16, 2023

We run the tests on every merge, it'd be ideal to continue using preemptible.

Oh, workspace integration test using harvester, not GCE

What makes you say?

sorry, I read it wrong.

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 16, 2023

/unhold

@roboquat roboquat merged commit 0352c45 into main Nov 16, 2023
57 of 69 checks passed
@roboquat roboquat deleted the pd/fix-broken-ci branch November 16, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants