Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete New Project page #19077

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Remove obsolete New Project page #19077

merged 4 commits into from
Nov 17, 2023

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Nov 15, 2023

Description

This PR removes the unused page from Dashboard, leaving the unused jsonrpc API methods as no-ops in place for compatibility reasons.

Summary generated by Copilot

🤖 Generated by Copilot at a259abc

This pull request refactors and simplifies the projects feature in the dashboard and the server, removing unused code and components related to GitHub, GitLab, and Bitbucket app support. It also makes the CreateProjectModal the only way to create a new project in the UI, and deprecates the createProject method in the GitpodServer interface.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@selfcontained selfcontained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much gone 😄 . Looks good to me. Tested out project creation flows and everything works.


return repositories;
await this.checkAndBlockUser("getProviderRepositoriesForUser");
return [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chefs-kiss

@AlexTugarev
Copy link
Member Author

/unhold

@AlexTugarev AlexTugarev force-pushed the at/rm-new-project-page branch from a259abc to fb5b0c5 Compare November 17, 2023 09:49
@roboquat roboquat merged commit 4b78a99 into main Nov 17, 2023
11 of 12 checks passed
@roboquat roboquat deleted the at/rm-new-project-page branch November 17, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants