-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[baseserver] Emit metrics for logs produced by level ENG-349 #19063
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5a87a11
[baseserver] Emit metrics for logs produced by level
easyCZ 13c9b02
fix
easyCZ d30f850
fix
easyCZ 32cd7c8
fix
easyCZ 6ca9468
fix
easyCZ 3ebebdb
Fix
easyCZ c4bfc6a
Fix
easyCZ aaf1d38
fix
easyCZ c5ae89e
retest
easyCZ 96ebcd2
fix
easyCZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
// Copyright (c) 2023 Gitpod GmbH. All rights reserved. | ||
// Licensed under the GNU Affero General Public License (AGPL). | ||
// See License.AGPL.txt in the project root for license information. | ||
|
||
package log | ||
|
||
import ( | ||
"github.com/prometheus/client_golang/prometheus" | ||
"github.com/sirupsen/logrus" | ||
) | ||
|
||
var ( | ||
DefaultMetrics = NewMetrics() | ||
) | ||
|
||
type Metrics struct { | ||
logEmitedCounter *prometheus.CounterVec | ||
} | ||
|
||
func (m *Metrics) ReportLog(level logrus.Level) { | ||
m.logEmitedCounter.WithLabelValues(level.String()).Inc() | ||
} | ||
|
||
func NewMetrics() *Metrics { | ||
return &Metrics{ | ||
logEmitedCounter: prometheus.NewCounterVec(prometheus.CounterOpts{ | ||
Name: "gitpod_logs_total", | ||
Help: "Total number of logs produced by level", | ||
}, []string{"level"}), | ||
} | ||
} | ||
|
||
// Describe sends the super-set of all possible descriptors of metrics | ||
// collected by this Collector to the provided channel and returns once | ||
// the last descriptor has been sent. | ||
func (m *Metrics) Describe(ch chan<- *prometheus.Desc) { | ||
m.logEmitedCounter.Describe(ch) | ||
} | ||
|
||
// Collect is called by the Prometheus registry when collecting | ||
// metrics. The implementation sends each collected metric via the | ||
// provided channel and returns once the last metric has been sent. | ||
func (m *Metrics) Collect(ch chan<- prometheus.Metric) { | ||
m.logEmitedCounter.Collect(ch) | ||
} | ||
|
||
func NewLogHook(metrics *Metrics) *LogHook { | ||
return &LogHook{metrics: metrics} | ||
} | ||
|
||
type LogHook struct { | ||
metrics *Metrics | ||
} | ||
|
||
func (h *LogHook) Levels() []logrus.Level { | ||
return logrus.AllLevels | ||
} | ||
|
||
func (h *LogHook) Fire(entry *logrus.Entry) error { | ||
h.metrics.ReportLog(entry.Level) | ||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log level here is uint32
type Level uint32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the method calls
which uses the string version