Print information after login #19029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
reviewed
Nov 7, 2023
components/local-app/cmd/login.go
Outdated
| @@ -66,7 +66,8 @@ var loginCmd = &cobra.Command{ | |||
|
|
|||
| err = auth.SetToken(loginOpts.Host, token) | |||
| if err != nil { | |||
| slog.Warn("could not write token to keyring, storing in config file instead", "err", err) | |||
| slog.Debug("could not write token to keyring, storing in config file instead") | |||
filiptronicek
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Works like a charm.
#19029 (comment) feels like worth addressing here, but otherwise 
.
components/local-app/cmd/whoami.go
Outdated
Comment on lines
43
to
44
| // printWhoami prints information about the currently logged in user | ||
| func whoami(ctx context.Context, client *client.Gitpod, gpctx *config.ConnectionContext) ([]whoamiResult, error) { |
There was a problem hiding this comment.
nit: there's a mismatch between the function name and its doc
components/local-app/cmd/login.go
Outdated
| @@ -66,7 +66,8 @@ var loginCmd = &cobra.Command{ | |||
|
|
|||
| err = auth.SetToken(loginOpts.Host, token) | |||
| if err != nil { | |||
| slog.Warn("could not write token to keyring, storing in config file instead", "err", err) | |||
| slog.Debug("could not write token to keyring, storing in config file instead") | |||
There was a problem hiding this comment.
Could be worth checking slog.Level here to omit duplicate output.
There was a problem hiding this comment.
Maybe add a common function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once login is successful, we now print more details about the login user. It's essentially the same as running "Who am I?" right after the login.
Summary generated by Copilot
🤖 Generated by Copilot at cffb2f4
This pull request enhances the user experience of the local-app
loginandwhoamicommands. It adds more logging and feedback for thelogincommand, and simplifies the code for both commands by using thecontextpackage and a shared helper function.Related Issue(s)
Fixes EXP-886
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold