change samesite for workspace owner cookie #19028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/cookie-test
branch
from
bc88f2c to
fbc22d3
Compare
geropl
reviewed
Nov 7, 2023
| @@ -358,12 +359,16 @@ export class UserController { | |||
| return; | |||
| } | |||
|
|
|||
| const useSameSiteNone = await getExperimentsClientForBackend().getValueAsync("sameSiteNone", false, { | |||
There was a problem hiding this comment.
What is the goal of introducing a feature flag here? I'd like to understand the motivation and broader idea before we merge sth like this. 🙂
E.g., if the problem is "public port" is to public, then this is not a fix, but makes it worse. 🤷
There was a problem hiding this comment.
I added a feature flag so we can disable it in case we overlooked something during testing
|
Not going with this because of https://developer.chrome.com/docs/privacy-sandbox/third-party-cookie-phase-out/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This relaxes the workspace owner cookie so it gets sent when the workspace URLs are used from within an iframe
Summary generated by Copilot
🤖 Generated by Copilot at bc88f2c
Fixed a cookie bug that prevented cross-site authentication between the workspace and dashboard domains. Changed the
sameSiteattribute of the cookie inuser-controller.tsto "none".Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold