[LocalCLI] add completion for --class and --editor flags
#19019
Conversation
mustard-mh
changed the title
--class and --editor flags
|
@filiptronicek if you can take a look 
|
| @@ -13,3 +13,13 @@ packages: | |||
| image: | |||
| - ${imageRepoBase}/local-app:${version} | |||
| - ${imageRepoBase}/local-app:commit-${__git_commit} | |||
|
|
|||
| scripts: | |||
| - name: install-cli | |||
There was a problem hiding this comment.
Could we do this automatically in the .gitpod.yml file for the initial install? Would maybe help with testing.
There was a problem hiding this comment.
We could add this to the README as well
There was a problem hiding this comment.
Yep, will do it 👍
There was a problem hiding this comment.
@filiptronicek Updated README.md feel free to update it again XD
| @@ -143,10 +143,53 @@ var workspaceCreateOpts struct { | |||
| Editor string | |||
| } | |||
|
|
|||
| func classCompletionFunc(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | |||
There was a problem hiding this comment.
@mustard-mh could we decouple this from here and move into the helpers package 🙏?
There was a problem hiding this comment.
@filiptronicek completion (api call + simple fmt.Sprintf) will only be used in cmd, if we move them to helpers, we need to move getGitpodClient and rootTestingOpts (using in unit test) out too. Not that worth to do it.
We can call classCompletionFunc any where in cmd package, so it's reusable now (i.e. add them to workspace up cmd 07ef7b7 )
There was a problem hiding this comment.
I think we could follow the approach of OpenWorkspaceInPreferredEditor, where we pass in the client (easier for testing with client mocks). Feel like it's good to avoid coupling commands together through functions.
I think like this it's also alright. Leaving it up to ya
|
|
Description
Add completion for
--classand--editorflags ofworkspace createcommandSummary generated by Copilot
🤖 Generated by Copilot at 1eb2534
Fix a typo in the
README.mdfile that breaks the HTML syntax. Reject the pull request as it does not follow the contribution guidelines and does not address any issue or feature request.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold