Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-rbac-proxy to v0.15.0 #18984

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update kube-rbac-proxy to v0.15.0 #18984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2251e37
Update kube-rbac-proxy to v0.15.0
aledbf Oct 30, 2023
776a515
Fix tests
aledbf Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions install/installer/pkg/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@ func KubeRBACProxyContainerWithConfig(ctx *RenderContext) *corev1.Container {
"--logtostderr",
fmt.Sprintf("--insecure-listen-address=[$(IP)]:%d", baseserver.BuiltinMetricsPort),
fmt.Sprintf("--upstream=http://127.0.0.1:%d/", baseserver.BuiltinMetricsPort),
"--http2-disable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last two releases are related to CVEs that exploit HTTP/2. Also, we don't need/use any HTTP/2 feature.

},
Ports: []corev1.ContainerPort{
{Name: baseserver.BuiltinMetricsPortName, ContainerPort: baseserver.BuiltinMetricsPort},
Expand Down
2 changes: 2 additions & 0 deletions install/installer/pkg/common/common_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestKubeRBACProxyContainer_DefaultPorts(t *testing.T) {
"--logtostderr",
fmt.Sprintf("--insecure-listen-address=[$(IP)]:%v", baseserver.BuiltinMetricsPort),
fmt.Sprintf("--upstream=http://%v/", common.LocalhostPrometheusAddr()),
"--http2-disable",
}, container.Args)
require.Equal(t, []corev1.ContainerPort{
{Name: baseserver.BuiltinMetricsPortName, ContainerPort: baseserver.BuiltinMetricsPort},
Expand All @@ -41,6 +42,7 @@ func TestKubeRBACProxyContainerWithConfig(t *testing.T) {
"--logtostderr",
fmt.Sprintf("--insecure-listen-address=[$(IP)]:%d", baseserver.BuiltinMetricsPort),
fmt.Sprintf("--upstream=http://%v/", common.LocalhostPrometheusAddr()),
"--http2-disable",
}, container.Args)
require.Equal(t, []corev1.ContainerPort{
{Name: baseserver.BuiltinMetricsPortName, ContainerPort: baseserver.BuiltinMetricsPort},
Expand Down
2 changes: 1 addition & 1 deletion install/installer/pkg/common/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const (
InClusterDbSecret = "mysql"
KubeRBACProxyRepo = "quay.io"
KubeRBACProxyImage = "brancz/kube-rbac-proxy"
KubeRBACProxyTag = "v0.14.2"
KubeRBACProxyTag = "v0.15.0"
MinioServiceAPIPort = 9000
MonitoringChart = "monitoring"
ProxyComponent = "proxy"
Expand Down
Loading