Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect start workspace url #18934

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 16, 2023

Description

Fix incorrect start workspace url, working for both case

workspace url dashboard url
image image
Summary generated by Copilot

🤖 Generated by Copilot at 852de59

Refactor GitpodHostUrl class and fix start URL bug. This pull request simplifies the URL manipulation logic in the GitpodHostUrl class and fixes a bug that caused the start URL to include the workspace ID twice in the urls.ts module.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh mustard-mh force-pushed the hw/fix-incorrect-redirect-url branch from 852de59 to 3c1b151 Compare October 16, 2023 14:07
@mustard-mh mustard-mh marked this pull request as ready for review October 16, 2023 14:08
@mustard-mh mustard-mh requested a review from a team as a code owner October 16, 2023 14:08
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not try, but change look sensible.

@roboquat roboquat merged commit 35d47fe into main Oct 17, 2023
26 checks passed
@roboquat roboquat deleted the hw/fix-incorrect-redirect-url branch October 17, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants