[public-api] add v2 WorkspaceService.getWorkspace #18930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a look now 👀 |
geropl
reviewed
Oct 17, 2023
|
|
||
| message GetWorkspaceRequest { string id = 1; } | ||
|
|
||
| message GetWorkspaceResponse { Workspace item = 1; } |
There was a problem hiding this comment.
nit: Has there been a discussion on the use of item as generic name for the contained element in the response?
Alternatively, one could name it specific to the resource type (workspace).
geropl
reviewed
Oct 17, 2023
| // and user. | ||
| // | ||
| // +optional | ||
| repeated WorkspaceEnvironmentVariable additional_environment_variables = 7; |
There was a problem hiding this comment.
☁️ All the following fields are part of the "spec", but also mirrored back as part of the "status". We could think about bringing this even closer to the kubernetes-style, and on the top level fully separate the two. But I think that's out of scope here, just leaving it if we think about this again int he future. 👍
geropl
approved these changes
Oct 17, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 446315d
This pull request adds the proto definition and the generated code for the WorkspaceService, a new experimental API for managing workspaces in Gitpod. It also removes a dependency on the gitpod-protocol library from the public-api typescript package, to avoid a circular dependency and a conflict with the existing typescript definitions. The generated code includes Connect and gRPC clients and servers in Go and typescript, as well as proxy handlers and service types. The WorkspaceService is part of a larger effort to improve the user experience and performance of Gitpod, by providing more granular and flexible control over workspaces and their resources.
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold