[dashboard] use list members and get invitation api #18920
Conversation
|
We discussed with @mustard-mh to try first new APIs and if it returns unimplemented then fallback to old behaviour. It would allows us to decouple from #18908 (comment) and deploy to Cloud already today. cc @easyCZ |
mustard-mh
force-pushed
the
hw/papi-list-team-dashboard
branch
from
dc000d0 to
487da46
Compare
|
Tested that unimplemented fallback works
|
|
@akosyakov to bring compatibility, should we add another API like If so, I will do it in this PR (with unimplemented fallback for sure) update: will do it |
| @@ -73,6 +84,9 @@ service TeamsService { | |||
| // ListTeams lists the caller has access to. | |||
| rpc ListTeams(ListTeamsRequest) returns (ListTeamsResponse) {}; | |||
|
|
|||
| // GetTeamList lists teams that the caller has access to. | |||
| rpc GetTeamList(GetTeamListRequest) returns (GetTeamListResponse) {}; | |||
There was a problem hiding this comment.
It is not consistent then with other functions. Maybe ListTeams2?
What was wrong with making properties optional in ListTeamsResponse?
There was a problem hiding this comment.
It is not consistent then with other functions. Maybe ListTeams2?
Sounds good
What was wrong with making properties optional in ListTeamsResponse?
@akosyakov The actual improvement we want is to remove respond of listTeam members property, so we need to update public api server. Once it's been removed, dashboard with old version will be broken.
In this case, deprecate or optional is the same. No compatibility if upgrade from old version
So if we thought this page/APIs are important and need more compatibility, then we should never deprecate related proto, But add new API and deprecate old API after a long time like x months
But I also ask questions for compatibility rollout [slack]. If we add compatibility code, it should be there for x months, I don't like it.
And we also want to introduce real PAPI, then the compatibility code will be 🤯
Or you mean that, check to code to see if optional members and invitation not affect anything important? We check isOwner from members, so it can affect lots of places
There was a problem hiding this comment.
We chatted today with Milan/Chris/Sven and outcome was to ensure order of component deployments in Dedicated and Cloud. Maybe it is what we should look next instead.
And particularly this time we will simply wait for complete rollout? let's chat tomorrow?
|
Close since this will be addressed with new papi org service |
Description
Part of #18908 (comment)
‼️ Blocked by #18919 to be deployedSummary generated by Copilot
🤖 Generated by Copilot at dc000d0
No summary available (Limit exceeded: required to process 84724 tokens, but only 50000 are allowed per call)
Related Issue(s)
Fixes EXP-775
How to test
owner,member, join my org with link )Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold