Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new repo list/detail routes behind flag #18918

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Oct 12, 2023

Description

Adds new placeholder pages and routes for the following pages behind a feature flag - repoConfigListAndDetail :

  • /repositories - Repository List
  • /repositories/:id - Repository Config Detail
Summary generated by Copilot

🤖 Generated by Copilot at 526729c

This pull request adds new components and routes for the repository list and detail pages, which are hidden behind a feature flag. It also adds the feature flag property to the featureFlags object and the featureflag-query module.

Related Issue(s)

Fixes EXP-794

How to test

Visit both of the routes by manually entering in the urls and making sure they render the placeholder page.

  • /repositories
  • /repositories/sample-id

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Removing the feature flag on my account makes it redirect to a 404 correctly.

image

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 3d899e5 into main Oct 13, 2023
48 of 49 checks passed
@roboquat roboquat deleted the brad/repos-routes branch October 13, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants