[proxy] Add /api/health 200 #18917
Merged
[proxy] Add /api/health 200 #18917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Oct 13, 2023
| @@ -195,6 +195,10 @@ https://{$GITPOD_DOMAIN} { | |||
| import ssl_configuration | |||
| import security_headers | |||
|
|
|||
| handle /api/health { | |||
There was a problem hiding this comment.
Adding a comment/link/references as to why this is here would be 🧡
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Such that a chained NLB can use the proxy's
/api/healthto determine the target's health. Currently/api/versionis used but that endpoint can change, and we'd break the NLBsSummary generated by Copilot
🤖 Generated by Copilot at c5d70f7
Add health check endpoint for proxy component. This allows external tools to verify that the
proxyservice is up and running by querying/healthzin theCaddyfile.Related Issue(s)
Fixes #
How to test
Preview, route to
/api/healthand get a 200Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold