Fix loading state bug when creating new workspace #18870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfcontained
changed the title
gtsiolis
approved these changes
Oct 4, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where on create workspace the editor & ws class hung in a loading state until a repo was selected. I've left the
optionsLoadedstate as it's used for preventing an autostart before we've loaded any previously used options, but am just not considering it for the loading state anymore.I also fixed a bug I noticed where multiple projects w/ same repo wouldn't show up correctly after you started searching.
Summary generated by Copilot
🤖 Generated by Copilot at 366cbf4
This pull request improves the user experience and performance of the
CreateWorkspacePagecomponent by simplifying the loading logic and avoiding repository conflicts. It affects the filesCreateWorkspacePage.tsxandunified-repositories-search-query.ts.How to test
Open Create Workspace and verify the editor and class selectors aren't disabled in a loading state even when you don't have a repo selected.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold