Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] CreateWorkspace Overflow bug fix #18854

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[UI] CreateWorkspace Overflow bug fix #18854

merged 1 commit into from
Oct 2, 2023

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Oct 2, 2023

Description

Before After
image image
Summary generated by Copilot

🤖 Generated by Copilot at 7d5fc84

Improve drop-down menu component in dashboard. Limit width and truncate text of selected element in DropDown2.tsx.

Related Issue(s)

Fixes EXP-748

How to test

  • Open preview
  • Open this file in gitpod. using {preview-env-url}/#
  • See UI 👀

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Siddhant-K-code. 🌮

Nice catch—clarifying here for anyone reading this that you need to first have the repository imported as a project to reproduce the issue.

/unhold

@roboquat roboquat merged commit 9179f65 into main Oct 2, 2023
69 of 71 checks passed
@roboquat roboquat deleted the fix/bug-ui branch October 2, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants