Privacy policy update alert #18852
Merged
Privacy policy update alert #18852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
securitymirco
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
@filiptronicek lgtm, thank you! Some minor feedback: perhaps we could say "We've updated our Privacy Policy. You can review it here"?"
filiptronicek
force-pushed
the
ft/privacy-policy-in-app
branch
from
1aea1f7 to
3b6dfcc
Compare
securitymirco
approved these changes
Oct 4, 2023
laushinka
approved these changes
Oct 13, 2023
| @@ -72,6 +72,10 @@ export class UserService { | |||
| // blocked = if user already blocked OR is not allowed to pass | |||
| newUser.blocked = newUser.blocked || !canPass; | |||
| } | |||
| if (newUser.additionalData) { | |||
| // When a user is created, it does not have `additionalData.profile` set, so it's ok to rewrite it here. | |||
| // newUser.additionalData.profile = { acceptedPrivacyPolicyDate: new Date().toISOString() }; | |||
There was a problem hiding this comment.
Did you mean to uncomment this or should we remove? I wonder if we need to present the privacy policy somewhere during signup if we don't already so that we could set it automatically like this?
There was a problem hiding this comment.
Meant to uncomment 🙈. @selfcontained we have this awesome little catch on our login pages which I believe allows us to do just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an alert about the privacy policy being updated. It also adds a mechanism for considering what was the last privacy policy the user has accepted and only show the alert if they haven't.
Summary generated by Copilot
🤖 Generated by Copilot at a77118a
This pull request adds a new feature to the dashboard that shows a banner alert to users who have not accepted the latest privacy policy. It also adds a new property to the user data to store the acceptance date, and updates the user creation and update logic accordingly. The changes affect the files
AppRoutes.tsx,AppNotifications.tsx,utils.ts,protocol.ts, anduser-service.ts.Related Issue(s)
Fixes EXP-15
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold