Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev image #18798

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Update dev image #18798

merged 5 commits into from
Sep 26, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 25, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at cf8f051

Refactor dev-environment Dockerfile and scripts to use public gitpod base image and simplify configuration.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@aledbf aledbf force-pushed the aledbf/update-image branch from 448bba6 to cd2b812 Compare September 25, 2023 23:49
@aledbf aledbf force-pushed the aledbf/update-image branch from b6e0296 to 642284a Compare September 26, 2023 00:45
@roboquat roboquat added size/XL and removed size/L labels Sep 26, 2023
@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

RUN brew install authzed/tap/spicedb
RUN brew install tmux tmuxinator \
# Install redis-server
&& brew install redis \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis is no longer versioned with this change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the version right now is 7.2.1. I tried to use @7, @7.2 but that is not supported

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % redis is unversioned, added hold

@roboquat roboquat merged commit c608516 into main Sep 26, 2023
15 checks passed
@roboquat roboquat deleted the aledbf/update-image branch September 26, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants