Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser Extension in-app banner #18796
Browser Extension in-app banner #18796
Changes from 21 commits
b84d909
3906bbf
eb36507
d70d278
9978c61
0af1e90
969510d
fb2d0a7
d324f0c
9158eb9
7be56cb
a5ebd3e
c80b0f3
6ad0f38
9bac699
32f71f2
8734871
15448ca
72b17ce
c574479
d879903
ea80759
0dc30e2
3b9f2fa
ffd5481
00f6553
9a04142
eb69108
fba7bae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we know what SCMs the user has registered the message would be clearer if it would say:
Open workspaces directly from github.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, think that it will make it clearer, and we can leave this as the fallback.
cc @loujaybee?