Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] add ssh tunnel metrics #18795

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 25, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at ce05a16

Add metrics for SSH tunneling in supervisor. The changes modify the supervisor, metrics, and ide-metrics components to define, track, and report the number of SSH tunnels opened and closed, and the reason for closing.

Related Issue(s)

Fixes #

How to test

  • Start a workspace with VS Code Desktop, connect, do something, and then stop.
  • Curl metrics on ide-metrics to see whether new metrics were registered.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@akosyakov akosyakov requested a review from a team as a code owner September 25, 2023 11:29
@akosyakov akosyakov force-pushed the ak/sup_ssh_tunnel_metrics branch 2 times, most recently from f18f7ca to 5f69b58 Compare September 25, 2023 11:53
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@akosyakov akosyakov marked this pull request as draft September 25, 2023 12:16
@akosyakov akosyakov force-pushed the ak/sup_ssh_tunnel_metrics branch from 5f69b58 to 2428aea Compare September 25, 2023 15:23
@akosyakov
Copy link
Member Author

akosyakov commented Sep 25, 2023

/gh run recreate-vm=true

Comment triggered a workflow run

Started workflow run: 6303475703

  • recreate_vm: true

@akosyakov akosyakov force-pushed the ak/sup_ssh_tunnel_metrics branch from 2428aea to 9ff1163 Compare September 25, 2023 18:55
@akosyakov akosyakov force-pushed the ak/sup_ssh_tunnel_metrics branch from 9ff1163 to 1fd00a7 Compare September 25, 2023 19:21
@akosyakov
Copy link
Member Author

Got it
Screenshot 2023-09-25 at 22 28 26

Also added info about remote addr, user agent, duration of connection, and system resources on failure to logs.

@akosyakov
Copy link
Member Author

/unhold

@akosyakov akosyakov marked this pull request as ready for review September 25, 2023 20:29
@roboquat roboquat merged commit 2565a1c into main Sep 25, 2023
14 checks passed
@roboquat roboquat deleted the ak/sup_ssh_tunnel_metrics branch September 25, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants