-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[supervisor] add ssh tunnel metrics #18795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/sup_ssh_tunnel_metrics
branch
2 times, most recently
from
September 25, 2023 11:53
f18f7ca
to
5f69b58
Compare
geropl
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
akosyakov
commented
Sep 25, 2023
akosyakov
force-pushed
the
ak/sup_ssh_tunnel_metrics
branch
from
September 25, 2023 15:23
5f69b58
to
2428aea
Compare
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 6303475703
|
akosyakov
force-pushed
the
ak/sup_ssh_tunnel_metrics
branch
from
September 25, 2023 18:55
2428aea
to
9ff1163
Compare
akosyakov
force-pushed
the
ak/sup_ssh_tunnel_metrics
branch
from
September 25, 2023 19:21
9ff1163
to
1fd00a7
Compare
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at ce05a16
Add metrics for SSH tunneling in supervisor. The changes modify the
supervisor
,metrics
, andide-metrics
components to define, track, and report the number of SSH tunnels opened and closed, and the reason for closing.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold