Revert "[dashboard] Downtime in-app announcements (#18761)" #18789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
approved these changes
Sep 25, 2023
Comment on lines
126
to
132
| <Button | ||
| type="secondary" | ||
| className="bg-transparent hover:bg-transparent" | ||
| <button | ||
| type="button" | ||
| className="bg-transparent p-1" | ||
| onClick={handleClose} | ||
| autoFocus={autoFocusClose} | ||
| > | ||
| <XSvg className="w-3 h-4 cursor-pointer" /> | ||
| </Button> | ||
| </button> |
There was a problem hiding this comment.
thought: We might want to keep these changes around, but should be fine to revert in this PR as we only use the closable prop in two instances, see relevant diff. 🏓
There was a problem hiding this comment.
Let's keep them right away!
This reverts commit cebee56, modulo some fixes we want to keep.
geropl
force-pushed
the
gpl/revert-downtime
branch
from
1a5845a to
8fd4c2a
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cebee56.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 1a5845a
Removed maintenance notifications and related code from the dashboard. Simplified the
AlertandAppRoutescomponents.Related Issue(s)
Fixes EXP-684
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold