Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation note to github node in .gitpod.yml – EXP-682 #18788

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 25, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at b6d8eda

Deprecated some unused or redundant properties of the github field in the Gitpod schema file, to streamline the prebuild settings and UX.

Related Issue(s)

Fixes EXP-682

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@AlexTugarev AlexTugarev requested a review from a team as a code owner September 25, 2023 06:26
@AlexTugarev AlexTugarev changed the title Add deprecation note to github node in .gitpod.yml Add deprecation note to github node in .gitpod.yml – EXP-682 Sep 25, 2023
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹 ✔️

@loujaybee
Copy link
Member

👋 Hey Alex—do we want to merge the documentation changes first before we merge this PR? Users might have questions and I'd want to avoid any confusion. What are your thoughts?

@AlexTugarev AlexTugarev force-pushed the at/deprecate-github-in-config branch from b6d8eda to 37456fe Compare September 25, 2023 06:36
@roboquat roboquat added size/M and removed size/S labels Sep 25, 2023
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Sep 25, 2023

@loujaybee, I'm happy to sync the two updates, absolutely!

@AlexTugarev
Copy link
Member Author

/unhold

@roboquat roboquat merged commit d897a6c into main Sep 29, 2023
14 checks passed
@roboquat roboquat deleted the at/deprecate-github-in-config branch September 29, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants