-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[content-service] download s3 content using s5cmd #18783
Conversation
61aa5c9
to
b808abd
Compare
👋 @aledbf I am going to deploy this branch to edit: I'll do some isolated testing, to observe performance. For example, when the maximum # of workspaces are starting on one node. If it works well, we can merge and ship to |
🚀 |
I am seeing some errors on workspace restart and stop:
This is pretty easily recreated by starting/restarting/stopping ~4 workspaces at once. I'll investigate more on Monday - to see if this is related or not. |
I was able to recreate this problem in |
Description
Use s5cmd to download s3 content
Summary generated by Copilot
🤖 Generated by Copilot at 61aa5c9
Improve S3 backup download speed and reliability by using
s5cmd
incontent-service
andws-daemon
.Related Issue(s)
Fixes ENG-884
How to test
Start workspaces from prebuilds in dev-internal, compare with dogfood. dogfood should take more than 2 times longer to start a workspace from a prebuild. Use the Gitpod mono repo project.
Refer to this gist to see how the related parameters were decided on for s5cmd.
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold