Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax assumptions in supervisor #18782

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Relax assumptions in supervisor #18782

merged 8 commits into from
Sep 27, 2023

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Sep 22, 2023

Description

Relaxes some prior assumptions around UID/GID and home directory in supervisor.

Summary generated by Copilot

🤖 Generated by Copilot at 78ecbdd

This pull request adds support for different workspace runtimes by using dynamic user and group values for the content initializer, the git client, the SSH server, and the supervisor component. It also refactors some code to use newer packages and adds a hidden command for debugging the content initializer.

Related Issue(s)

Contributes to ENG-824

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From smoke testing the changes w/ and wo/ dotfiles, everything looks good.

@roboquat roboquat merged commit 9a38b60 into main Sep 27, 2023
@roboquat roboquat deleted the cw/supervisor-ng branch September 27, 2023 14:32
akosyakov added a commit that referenced this pull request Oct 2, 2023
roboquat pushed a commit that referenced this pull request Oct 2, 2023
Furisto added a commit that referenced this pull request Oct 5, 2023
csweichel pushed a commit that referenced this pull request Oct 17, 2023
csweichel pushed a commit that referenced this pull request Oct 17, 2023
csweichel pushed a commit that referenced this pull request Oct 17, 2023
aledbf pushed a commit that referenced this pull request Oct 17, 2023
csweichel pushed a commit that referenced this pull request Nov 9, 2023
csweichel pushed a commit that referenced this pull request Nov 9, 2023
Furisto added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants