-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax assumptions in supervisor #18782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
approved these changes
Sep 22, 2023
filiptronicek
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From smoke testing the changes w/ and wo/ dotfiles, everything looks good.
Furisto
approved these changes
Sep 25, 2023
roboquat
pushed a commit
that referenced
this pull request
Oct 2, 2023
Furisto
added a commit
that referenced
this pull request
Oct 5, 2023
csweichel
pushed a commit
that referenced
this pull request
Oct 17, 2023
csweichel
pushed a commit
that referenced
this pull request
Oct 17, 2023
csweichel
pushed a commit
that referenced
this pull request
Oct 17, 2023
aledbf
pushed a commit
that referenced
this pull request
Oct 17, 2023
csweichel
pushed a commit
that referenced
this pull request
Nov 9, 2023
csweichel
pushed a commit
that referenced
this pull request
Nov 9, 2023
Furisto
added a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relaxes some prior assumptions around UID/GID and home directory in supervisor.
Summary generated by Copilot
🤖 Generated by Copilot at 78ecbdd
This pull request adds support for different workspace runtimes by using dynamic user and group values for the content initializer, the git client, the SSH server, and the supervisor component. It also refactors some code to use newer packages and adds a hidden command for debugging the content initializer.
Related Issue(s)
Contributes to ENG-824
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold