Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fga] trying to understand the sharing issue #18766

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Sep 21, 2023

Description

Adding logs to the situation where the old system grants workspace get but the new one doesn't.
So hopefully we can better understand what could be the reason.

Summary generated by Copilot

🤖 Generated by Copilot at f62db8e

This pull request implements fine-grained access control (FGA) checks for workspace access and organization membership, and fixes some related bugs. It adds a forceEnablement parameter to the SpiceDBAuthorizer class and the authorizer.ts module to enable FGA checks for debugging. It also updates the gitpod-server-impl.ts file to use the new parameter and correct some errors.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✔️

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit d88fe05 into main Sep 21, 2023
65 of 71 checks passed
@roboquat roboquat deleted the fga-more-logging branch September 21, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants