-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add private registry support for Dockerfile image build #18760
Conversation
15183cd
to
825aff2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do we have a way to extend the unit tests to show the logic exhibits the desired behaviour? If so, could you try to add them, please?
I haven't found a suitable way to add unit tests, on one hand this requires a patched version for buildkitd and also a registry server, plus these are still dependent on the domain name for forwarding, which makes the whole thing very complicated, I'm leaning towards merging this PR for now, and if I have the time I may add unit tests in another PR. |
/unhold |
Does this PR make the work in #18604 redundant? |
Hey @ChevronTango! Indeed, it seems that your work is covered by this PR as well. Do you need any help to test whether it solves your use case? |
Description
Add private registry support for Dockerfile image build
Summary generated by Copilot
🤖 Generated by Copilot at a1bfd46
This pull request adds support for ECR registries as mirrors for image building, by introducing changes to the
proxy
,auth
, andorchestrator
packages, and by using a custom buildkit image with a patched containerd. This feature allows users to specify ECR registries as sources for their workspace images, and improves the performance and reliability of image building.Related Issue(s)
Fixes PRD-111
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold