Remove unnecessary call to imageBuilder.needsImageBuild #18759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/ws-starter-imagebuilds
branch
from
97a61b7 to
6b4e6f5
Compare
geropl
changed the title
…t need it anymore Before, we used it to decide between handling the startWorkspace request sync or async. Now we are always async. And the check whether we actually need an image build is done in "build" anyway.
geropl
force-pushed
the
gpl/ws-starter-imagebuilds
branch
from
6b4e6f5 to
e19427f
Compare
geropl
changed the title
WVerlaek
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
lgtm, good cleanup 👍
from what I can tell this makes sense to do, both .build() and .resolveWorkspaceImage() on the image builder client result in the same internal check in image-builder-mk3 for whether the image exists. Also ran some tests in the preview env and looks good!
svenefftinge
approved these changes
Sep 26, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, we used it to decide between handling the startWorkspace request sync or async, based on whether the instances needed a docker image build or not. Now we are always async, so we can get rid of the old call to image-builder. Plus the check whether we actually need an image build is done in "build" anyway.
@WVerlaek for confirming ☝️ 🙏
Summary generated by Copilot
🤖 Generated by Copilot at 97a61b7
This pull request improves the error handling and logging for the workspace start operation and the entitlement service. It also adds a utility function to check for gRPC errors and a new metric value for image build failures. It affects the files
entitlement-service.ts,workspace-service.ts,workspace-starter.ts,grpc.ts, andprometheus-metrics.ts.Related Issue(s)
Fixes EXP-676
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold