Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Update mocha and remove resolutions #18736

Merged
merged 6 commits into from
Sep 19, 2023
Merged

🧹 Update mocha and remove resolutions #18736

merged 6 commits into from
Sep 19, 2023

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 18, 2023

Description

'Extracted this change from #18734 as it's primarily chores.

This no more:
Screenshot 2023-09-18 at 15 23 58

Summary generated by Copilot

🤖 Generated by Copilot at 295b5d7

This pull request updates and simplifies the mocha test configuration and dependencies for several packages in the gitpod-io/gitpod repository. It also fixes a security issue with minimatch and removes unnecessary mocha.opts files and resolutions from the package.json files.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@socket-security
Copy link

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
minimatch 9.0.3 environment +1 445 kB isaacs
@types/mocha 2.2.48...10.0.1, 5.2.7...10.0.1 None +0/-0 96.3 kB types
mocha 4.1.0...10.2.0, 5.2.0...10.2.0 None +78/-60 7.9 MB juergba

@AlexTugarev AlexTugarev changed the title Update mocha and remove resolutions 🧹 Update mocha and remove resolutions Sep 18, 2023
@geropl
Copy link
Member

geropl commented Sep 18, 2023

Will run https://github.com/gitpod-io/gitpod/actions/workflows/lacework-inline-scanner.yml to check the docker images once we got a build.

@geropl
Copy link
Member

geropl commented Sep 18, 2023

[components/ws-manager-bridge:app] TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /var/tmp/build/components-ws-manager-bridge--app.cff94b26da41d14c0735860adb15fbccf1540058/node_modules/@gitpod/gitpod-protocol/src/context-url.spec.ts

Could be that leeway does not like/support custom fields in package.json, which might be the reason we kept the separate config files... will try to figure out in a workspace.

@AlexTugarev
Copy link
Member Author

@geropl, on #18736 (comment)

No, it's just me, trying to remove unnecessary things. I've only tested with leeway andgitpod-protocol in the workspace and pushed to remote. But the exclude is actually useful for all dependants. The fix is building.

@geropl
Copy link
Member

geropl commented Sep 18, 2023

No, it's just me, trying to remove unnecessary things. I've only tested with leeway andgitpod-protocol in the workspace and pushed to remote. But the exclude is actually useful for all dependants. The fix is building.

Noticed the node_modules in the path now. Works indeed! 🎉

@AlexTugarev
Copy link
Member Author

Now we just™️ need to get a green build.

[components/server:app] Error in fetching sampling strategy: Error: connect ECONNREFUSED 0.0.0.0:5778.

🤷🏻‍♂️ this doesn't sound like a change caused by this PR.

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Sep 19, 2023

Trying to understand the build problem using leeway build components/public-api-server:app --cache=none

Can reproduce on this branch. Let's try with no cache on main. It might be a general problem, the issue is with this branch is that it touches a lot of components, i.e. it invalidates all cached state.

Got it! It's the wrong spec selection. On it!

@AlexTugarev
Copy link
Member Author

@AlexTugarev
Copy link
Member Author

/unhold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ 🧹

@roboquat roboquat merged commit 0189623 into main Sep 19, 2023
29 of 30 checks passed
@roboquat roboquat deleted the at/mocha branch September 19, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants