Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Remove feature flag workspace_start_controller #18735

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 18, 2023

Description

Let's merge this after we completely rolled this out

Summary generated by Copilot

🤖 Generated by Copilot at 7b0239c

This pull request removes the legacy code for the workspace start controller and starter, and fully adopts the new implementation. This improves the code quality and consistency of the workspace launch process on Kubernetes.

Related Issue(s)

Fixes EXP-636

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl geropl marked this pull request as ready for review October 11, 2023 14:09
@geropl geropl requested a review from a team as a code owner October 11, 2023 14:09
@geropl
Copy link
Member Author

geropl commented Oct 13, 2023

/unhold

@roboquat roboquat merged commit 8202ae5 into main Oct 13, 2023
15 checks passed
@roboquat roboquat deleted the gpl/rm-wsc-ff branch October 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants